Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing uint256 Cast #148

Open
code423n4 opened this issue Sep 16, 2021 · 2 comments
Open

Missing uint256 Cast #148

code423n4 opened this issue Sep 16, 2021 · 2 comments
Labels
0 (Non-critical) bug Something isn't working sponsor disputed

Comments

@code423n4
Copy link
Contributor

Handle

leastwood

Vulnerability details

Impact

Although solidity inherently casts uint128 to uint256 in BatchAuction.finalize():L288, explicitly casting marketInfo.totalTokens ensures that variables are properly casted.

Proof of Concept

https://github.com/sushiswap/miso/blob/master/contracts/Auctions/BatchAuction.sol#L288

Tools Used

Manual code review

Recommended Mitigation Steps

Cast marketInfo.totalTokens from uint128 to uint256.
@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Sep 16, 2021
code423n4 added a commit that referenced this issue Sep 16, 2021
@code423n4
leastwood issue #148
26a37da
@Clearwood
Copy link
Collaborator

It is better style but I would argue that it does not constitute a bug

@ghoul-sol
Copy link
Collaborator

non-cirtical issues can be a styling suggestion or best practice recommendation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working sponsor disputed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Clearwood @ghoul-sol @code423n4