We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WatchPug
https://github.com/code-423n4/2021-09-wildcredit/blob/c48235289a25b2134bb16530185483e8c85507f8/contracts/LendingPair.sol#L338-L339
_supplyBalanceConverted is unnecessary when fromToken and toToken are the same. Change to _supplyOf can save gas.
_supplyBalanceConverted
fromToken
toToken
_supplyOf
uint creditA = _supplyBalanceConverted(_account, tokenA, tokenA, priceA, priceA) * colFactorA / 100e18; uint creditB = _supplyBalanceConverted(_account, tokenB, tokenA, priceB, priceA) * colFactorB / 100e18;
Change to:
uint creditA = _supplyOf(tokenA, _account) * colFactorA / 100e18; uint creditB = _supplyBalanceConverted(_account, tokenB, tokenA, priceB, priceA) * colFactorB / 100e18;
The text was updated successfully, but these errors were encountered:
WatchPug issue #32
9e1d421
No branches or pull requests
Handle
WatchPug
Vulnerability details
https://github.com/code-423n4/2021-09-wildcredit/blob/c48235289a25b2134bb16530185483e8c85507f8/contracts/LendingPair.sol#L338-L339
_supplyBalanceConverted
is unnecessary whenfromToken
andtoToken
are the same. Change to_supplyOf
can save gas.Recommendation
Change to:
The text was updated successfully, but these errors were encountered: