Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal functions can be private #70

Open
code423n4 opened this issue Oct 22, 2021 · 0 comments
Open

internal functions can be private #70

code423n4 opened this issue Oct 22, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

These internal functions are never called in any contract that inherits their contract:

  • Swap.fillZrxQuote()
  • Swap.signifiesETHOrZero()
  • EmergencyGovernable.governor()

Therefore, their visibility can be reduced to private.

Impact

private functions are cheaper than internal functions.

Tool Used

Manual code review.

Recommended Mitigation Steps

Define these functions as private.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Oct 22, 2021
code423n4 added a commit that referenced this issue Oct 22, 2021
@code423n4
pants issue #70
7521faa
@Shadowfiend Shadowfiend added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Oct 29, 2021
@0xean 0xean mentioned this issue Nov 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shadowfiend @code423n4