Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas: Explicit overflow checks even though solidity 0.8 is used (2) #75

Open
code423n4 opened this issue Oct 20, 2021 · 1 comment
Open
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The UToken contract uses solidity version 0.8 which already comes with implicit overflow checks.
The explicit overflow checks in removeReserves can be removed:

// We checked reduceAmount <= totalReserves above, so this should never revert.
// @audit this overflow check already happened implicitly
require(totalReservesNew <= totalReserves, "reduce reserves unexpected underflow");
code423n4 added a commit that referenced this issue Oct 20, 2021
@GeraldHost GeraldHost added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 23, 2021
@GalloDaSballo
Copy link
Collaborator

Agree with finding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

3 participants