Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UToken.sol _redeemFresh could be set private instead internal #95

Open
code423n4 opened this issue Oct 20, 2021 · 1 comment
Open

UToken.sol _redeemFresh could be set private instead internal #95

code423n4 opened this issue Oct 20, 2021 · 1 comment
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

This is one of many examples of the appearance of private instead of internal. Since we manually code reviewing and writing issues we don't list all the appearances.
Calling a private function is more gas efficient than calling internal.

Here we refer to UToken.sol._redeemFresh function that is used only in UToken.sol file.
code423n4 added a commit that referenced this issue Oct 20, 2021
@code423n4
pants issue #95
f2684a9
@GeraldHost GeraldHost added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 23, 2021
@GalloDaSballo
Copy link
Collaborator

Agree with the specific example given as UToken is not inherited from any contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @GeraldHost @code423n4