Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRIBERageQuit: Redundant oracleAddress variable #108

Open
code423n4 opened this issue Dec 2, 2021 · 1 comment
Open

TRIBERageQuit: Redundant oracleAddress variable #108

code423n4 opened this issue Dec 2, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

hickuphh3

Vulnerability details

Impact

The following line

address public constant oracleAddress =
	0xd1866289B4Bd22D453fFF676760961e0898EE9BF; // oracle with caching

is only used in the instantiation of the oracle

IOracle public constant oracle = IOracle(oracleAddress);

The first instantiation can be combined with the second to save gas.

Recommended Mitigation Steps

IOracle public constant oracle = IOracle(0xd1866289B4Bd22D453fFF676760961e0898EE9BF);
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 2, 2021
code423n4 added a commit that referenced this issue Dec 2, 2021
@code423n4
hickuphh3 issue #108
cae0708
@elee1766 elee1766 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 6, 2021
@pauliax
Copy link
Collaborator

pauliax commented Dec 10, 2021

Valid optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elee1766 @pauliax @code423n4