Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedRecords: createRecord() can have modifier check removed #126

Open
code423n4 opened this issue Nov 17, 2021 · 2 comments
Open

NestedRecords: createRecord() can have modifier check removed #126

code423n4 opened this issue Nov 17, 2021 · 2 comments
Assignees
@maximebrugel
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

GreyArt

Vulnerability details

Impact

createRecord() is only invoked by store(). The onlyFactory check already exists in store(), so this modifier is redundant in createRecord().

Recommended Mitigation Steps

Remove the onlyFactory modifier.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
GreyArt issue #126
b373c74
@maximebrugel maximebrugel added the duplicate This issue or pull request already exists label Nov 19, 2021
@maximebrugel
Copy link
Collaborator

Duplicated : #124

@alcueca
Copy link
Collaborator

alcueca commented Dec 3, 2021

Not a duplicate

@alcueca alcueca reopened this Dec 3, 2021
@maximebrugel maximebrugel self-assigned this Dec 10, 2021
@maximebrugel maximebrugel mentioned this issue Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximebrugel @alcueca @code423n4