Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary balanceOf call in NestedBuybacker::triggerForToken #65

Open
code423n4 opened this issue Nov 15, 2021 · 0 comments
Open

Remove unnecessary balanceOf call in NestedBuybacker::triggerForToken #65

code423n4 opened this issue Nov 15, 2021 · 0 comments
Assignees
@maximebrugel
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pmerkleplant

Vulnerability details

Function triggerForToken in NestedBuybacker.sol makes a balanceOf call on
the _sellToken, see line 100.

However, the result of the call is never used.

It would save gas to remove the unnecessary call and variable declaration.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@code423n4
pmerkleplant issue #65
66ad97e
@maximebrugel maximebrugel added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 16, 2021
This was referenced Nov 16, 2021
Closed
Closed
@adrien-supizet adrien-supizet mentioned this issue Nov 19, 2021
Closed
This was referenced Nov 22, 2021
Closed
Merged
@maximebrugel maximebrugel self-assigned this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebrugel maximebrugel

Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximebrugel @code423n4