Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect naming issue #26

Open
code423n4 opened this issue Nov 19, 2021 · 0 comments
Open

Incorrect naming issue #26

code423n4 opened this issue Nov 19, 2021 · 0 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

xYrYuYx

Vulnerability details

Impact

https://github.com/code-423n4/2021-11-overlay/blob/main/contracts/OverlayV1UniswapV3Market.sol#L171

_tickToPrice function has underscore even it is public function.
Underscore is used to indicate internal or private functions.

Tools Used

Manual

Recommended Mitigation Steps

Change function to internal or private, or remove underscore if you want to keep it as public function.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 19, 2021
code423n4 added a commit that referenced this issue Nov 19, 2021
@code423n4
xYrYuYx issue #26
d800af8
@mikeyrf mikeyrf added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 7, 2021
This was referenced Dec 10, 2021
Closed
Closed
@mikeyrf mikeyrf mentioned this issue Dec 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeyrf @code423n4