Skip to content

Issues: code-423n4/2021-11-unlock-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152 Open 90 Closed
152 Open 90 Closed
Author
Filter by author
Label
Filter by label
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Milestones
Filter by milestone
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

MixinPurchase:shareKey allows to generate keys without purchasing 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#242 opened Nov 24, 2021 by code423n4
4
address(this).address2Str() bug Something isn't working G (Gas Optimization)
#241 opened Nov 24, 2021 by code423n4
1
++/-- are cheapest bug Something isn't working G (Gas Optimization)
#240 opened Nov 24, 2021 by code423n4
0 valueInETH bug Something isn't working G (Gas Optimization)
#239 opened Nov 24, 2021 by code423n4
assigned operations to constant variables bug Something isn't working G (Gas Optimization)
#238 opened Nov 24, 2021 by code423n4
timePlusFee = timeRemaining bug Something isn't working G (Gas Optimization)
#237 opened Nov 24, 2021 by code423n4
Refund amount and penalty calculation bug Something isn't working G (Gas Optimization)
#236 opened Nov 24, 2021 by code423n4
Unnecessary checks bug Something isn't working G (Gas Optimization)
#234 opened Nov 24, 2021 by code423n4
Precalculate expressions bug Something isn't working G (Gas Optimization)
#233 opened Nov 24, 2021 by code423n4
Unlock:_deployProxyAdmin return value is not used bug Something isn't working G (Gas Optimization)
#232 opened Nov 24, 2021 by code423n4
Store owners in EnumerableSet 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#231 opened Nov 24, 2021 by code423n4
Distribution of tokens in recordKeyPurchase 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working
#230 opened Nov 24, 2021 by code423n4
3
Validations 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working
#228 opened Nov 24, 2021 by code423n4
3
Unlock:createLock no need to define the newLock as payable bug Something isn't working G (Gas Optimization)
#226 opened Nov 24, 2021 by code423n4
1
onKeyPurchase hook expects amount + discount 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#225 opened Nov 24, 2021 by code423n4
1
Interface and implementation differ 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
#224 opened Nov 24, 2021 by code423n4
1
_cancelAndRefund is not protected from re-entrancy 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working
#223 opened Nov 24, 2021 by code423n4
2
tokenByIndex returns wrong token id 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#222 opened Nov 24, 2021 by code423n4
1
Support of different ERC20 tokens 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working
#221 opened Nov 24, 2021 by code423n4
5
msg.value should be 0 when token is not native 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
#220 opened Nov 24, 2021 by code423n4
1
Unable to change token approval when tokenAddress changed 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
#215 opened Nov 24, 2021 by code423n4
2
Gas optimization: Unused variable yieldedDiscountTokens bug Something isn't working G (Gas Optimization)
#213 opened Nov 24, 2021 by code423n4
Inconsistent code and comment 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
#212 opened Nov 24, 2021 by code423n4
3
Gas improvement on the nonce increment bug Something isn't working G (Gas Optimization)
#210 opened Nov 24, 2021 by code423n4
Inconsistent use of _msgSender() bug Something isn't working G (Gas Optimization)
#209 opened Nov 24, 2021 by code423n4
ProTip! Type g i on any issue or pull request to go back to the issue listing page.