Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input validation #77

Open
code423n4 opened this issue Nov 23, 2021 · 1 comment
Open

input validation #77

code423n4 opened this issue Nov 23, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

sabtikw

Vulnerability details

Impact

not input validation in below functions which would return ambiguous values

function publicLockVersions(address _impl) external view returns(uint16)

and

function publicLockImpls(uint16 _version) external view returns(address)

Proof of Concept

function publicLockVersions(address _impl) external view returns(uint16) {
return _publicLockVersions[_impl];
}

function publicLockImpls(uint16 _version) external view returns(address) {
return _publicLockImpls[_version];
}

Tools Used

manual review

Recommended Mitigation Steps

add require statement
require (_publicLockVersions[_impl] != 0, "NOT FOUND")

require(_publicLockImpls[_version] != address(0), "NOT FOUND")
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 23, 2021
code423n4 added a commit that referenced this issue Nov 23, 2021
@code423n4
sabtikw issue #77
39d3149
@julien51
Copy link
Collaborator

julien51 commented Jan 3, 2022

Duplicate #79

@julien51 julien51 added duplicate This issue or pull request already exists sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons labels Jan 3, 2022
@0xleastwood 0xleastwood mentioned this issue Jan 16, 2022
Closed
@0xleastwood 0xleastwood removed the duplicate This issue or pull request already exists label Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@julien51 @0xleastwood @code423n4