Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitepaper and code declares different conversion rates #236

Closed
code423n4 opened this issue Nov 15, 2021 · 0 comments
Closed

Whitepaper and code declares different conversion rates #236

code423n4 opened this issue Nov 15, 2021 · 0 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working ProtocolConstants resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

The whitepaper states that Vader <-> VETH conversion rate is 10'000:1, however it seems that the code declares a different rate:

 // Vader -> Vether Conversion Rate (1000:1)
 uint256 internal constant _VADER_VETHER_CONVERSION_RATE = 1000;

https://github.com/vetherasset/vaderprotocol-whitepaper/blob/main/Vader%20Protocol%20Whitepaper%20V2.pdf

Recommended Mitigation Steps

Consider updating the whitepaper and the codebase to match each other.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@code423n4
pauliax issue #236
b696889
@SamSteinGG SamSteinGG added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 25, 2021
@SamSteinGG SamSteinGG added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working ProtocolConstants resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@code423n4 @SamSteinGG @0xstormtrooper