Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only using SafeMath when necessary can save gas #281

Open
code423n4 opened this issue Dec 22, 2021 · 1 comment
Open

Only using SafeMath when necessary can save gas #281

code423n4 opened this issue Dec 22, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

For the arithmetic operations that will never over/underflow, using SafeMath will cost more gas.

For example:

https://github.com/code-423n4/2021-12-yetifinance/blob/5f5bf61209b722ba568623d8446111b1ea5cb61c/packages/contracts/contracts/BorrowerOperations.sol#L791-L795

if (_debtChange > _variableYUSDFee) { // if debt decrease, and greater than variable fee, decrease 
    newDebt = _troveManager.decreaseTroveDebt(_borrower, _debtChange.sub(_variableYUSDFee));
} else { // otherwise increase by opposite subtraction
    newDebt = _troveManager.increaseTroveDebt(_borrower, _variableYUSDFee.sub(_debtChange));
}

_debtChange - _variableYUSDFee at L792 and _variableYUSDFee - _debtChange at L794 will never underflow.

https://github.com/code-423n4/2021-12-yetifinance/blob/5f5bf61209b722ba568623d8446111b1ea5cb61c/packages/contracts/contracts/YUSDToken.sol#L240-L241

_totalSupply = _totalSupply.add(amount);
_balances[account] = _balances[account].add(amount);

_balances[account] + amount will not overflow if _totalSupply.add(amount) dose not overflow.

https://github.com/code-423n4/2021-12-yetifinance/blob/5f5bf61209b722ba568623d8446111b1ea5cb61c/packages/contracts/contracts/YUSDToken.sol#L248-L249

_balances[account] = _balances[account].sub(amount, "ERC20: burn amount exceeds balance");
_totalSupply = _totalSupply.sub(amount);

_totalSupply - amount will not underflow if _balances[account].sub(amount) dose not underflow.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 22, 2021
code423n4 added a commit that referenced this issue Dec 22, 2021
@kingyetifinance
Copy link
Collaborator

Similar to #85 but not exactly same.

@kingyetifinance kingyetifinance added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

2 participants