Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use variables indtead of array to save gas #119

Open
code423n4 opened this issue Jan 31, 2022 · 0 comments
Open

use variables indtead of array to save gas #119

code423n4 opened this issue Jan 31, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

CertoraInc

Vulnerability details

UniswapHelper.sol (_ensurePriceStability() function)

you save the storage array localFlanQuotes to a local (memory) array, but it is more efficient to save it's 2 elements to 2 local variables (this saves the calculating of the address by the index of the array's element and saves some gas)

code before:

FlanQuote[2] memory localFlanQuotes; //save gas
localFlanQuotes[0] = latestFlanQuotes[0];
localFlanQuotes[1] = latestFlanQuotes[1];

code after:

FlanQuote memory localFlanQuotes0, localFlanQuotes1;
localFlanQuotes0 = latestFlanQuotes[0];
localFlanQuotes1 = latestFlanQuotes[1];
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 31, 2022
code423n4 added a commit that referenced this issue Jan 31, 2022
@gititGoro gititGoro added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Feb 2, 2022
@gititGoro gititGoro added unresolved indicate confirmed issues that haven't been resolved with a PR and removed unresolved indicate confirmed issues that haven't been resolved with a PR labels May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

2 participants