Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using operator && used more gas #274

Open
code423n4 opened this issue Jan 13, 2022 · 0 comments
Open

using operator && used more gas #274

code423n4 opened this issue Jan 13, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

Tomio

Vulnerability details

Impact

using double require instead of operator && can save more gas

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/Vault.sol#L154

Recommended Mitigation Steps

example:

using &&:

function check(uint x)public view{
    require(x == 0 && x < 1 );
}

// gas cost 21630

using double require:

    require(x == 0 );
    require( x < 1);
    }
}
// gas cost 21622

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 13, 2022
code423n4 added a commit that referenced this issue Jan 13, 2022
@oishun1112 oishun1112 added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Jan 17, 2022
@yuta-mine yuta-mine assigned yuta-mine and unassigned yuta-mine Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

3 participants