Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas: Contracts inheriting InsureDAOERC20 don't need to import some dependencies *again* #78

Open
code423n4 opened this issue Jan 9, 2022 · 0 comments
Assignees
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

Dravee

Vulnerability details

Impact

When a contract imports and implements an interface or another contracts, it doesn't need to import the libraries that were already imported there.

Removing these imports will save gas.

Proof of Concept

InsureDAOERC20 imports the following:

5: import "@openzeppelin/contracts/token/ERC20/IERC20.sol";
6: import "@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol";

The following contracts inherit InsureDAOERC20 and also make those imports: CDSTemplate, IndexTemplate, PoolTemplate

Tools Used

VS Code

Recommended Mitigation Steps

Remove the unused imports to reduce the size of the contract and save some deployment gas.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 9, 2022
code423n4 added a commit that referenced this issue Jan 9, 2022
@oishun1112 oishun1112 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 13, 2022
@oishun1112 oishun1112 added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

3 participants