Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent accidentally burning tokens #120

Closed
code423n4 opened this issue Feb 1, 2022 · 2 comments
Closed

Prevent accidentally burning tokens #120

code423n4 opened this issue Feb 1, 2022 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working invalid This doesn't seem right

Comments

@code423n4
Copy link
Contributor

Handle

Dravee

Vulnerability details

Impact

Transferring tokens to the zero address is usually prohibited to accidentally avoid "burning" tokens by sending them to an unrecoverable zero address.

Proof of Concept

Places where I couldn't find a zero address check (or where the destination isn't a zero-checked address):

contracts\ControllerV1.sol:321:        oleToken.transfer(to, amount);
contracts\OLETokenLock.sol:51:        token.transfer(beneficiary, releaseAmount);

Tools Used

VS Code

Recommended Mitigation Steps

Add a check to prevent accidentally burning tokens
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Feb 1, 2022
code423n4 added a commit that referenced this issue Feb 1, 2022
@code423n4
Dravee issue #120
3eb29c3
@ColaM12 ColaM12 added the duplicate This issue or pull request already exists label Feb 2, 2022
@ColaM12
Copy link
Collaborator

ColaM12 commented Feb 2, 2022

Duplicate to #57

@ColaM12 ColaM12 closed this as completed Feb 2, 2022
@0xleastwood 0xleastwood added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Feb 19, 2022
@0xleastwood
Copy link
Collaborator

Closing in favour of #190

@0xleastwood 0xleastwood added invalid This doesn't seem right and removed duplicate This issue or pull request already exists labels Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xleastwood @code423n4 @ColaM12