Missing zero address validation

[code423n4]

Handle

Dravee

Vulnerability details

This is actually an automated finding from Slither.

This output might be informational due to design choices (gas savings for non-zero address checks).

I checked and there don't seem to be false positives.

Slither's output

OLEToken.constructor(address,address,string,string)._admin (gov/OLEToken.sol#41) lacks a zero-check on :
		- admin = _admin (gov/OLEToken.sol#42)
OpenLevDelegator.constructor(address,address,address[],address,address,uint8[],address,address).implementation_ (OpenLevDelegator.sol#22) lacks a zero-check on :
		- implementation = implementation_ (OpenLevDelegator.sol#34)
OpenLevDelegator.constructor(address,address,address[],address,address,uint8[],address,address)._admin (OpenLevDelegator.sol#21) lacks a zero-check on :
		- admin = _admin (OpenLevDelegator.sol#37)
OpenLevDelegator.setImplementation(address).implementation_ (OpenLevDelegator.sol#44) lacks a zero-check on :
		- implementation = implementation_ (OpenLevDelegator.sol#46)
OpenLevV1Lib.doTransferOut(address,IERC20,address,uint256).to (OpenLevV1Lib.sol#250) lacks a zero-check on :
		- address(to).transfer(amount) (OpenLevV1Lib.sol#253)
Timelock.constructor(address,uint256).admin_ (gov/Timelock.sol#32) lacks a zero-check on :
		- admin = admin_ (gov/Timelock.sol#36)
Timelock.setPendingAdmin(address).pendingAdmin_ (gov/Timelock.sol#67) lacks a zero-check on :
		- pendingAdmin = pendingAdmin_ (gov/Timelock.sol#74)
Timelock.executeTransaction(address,uint256,string,bytes,uint256).target (gov/Timelock.sol#117) lacks a zero-check on :
		- (success,returnData) = target.call{value: value}(callData) (gov/Timelock.sol#137)
ControllerV1.initialize(IERC20,address,address,address,address,DexAggregatorInterface,bytes)._xoleToken (ControllerV1.sol#35) lacks a zero-check on :
		- xoleToken = _xoleToken (ControllerV1.sol#44)
ControllerV1.initialize(IERC20,address,address,address,address,DexAggregatorInterface,bytes)._wETH (ControllerV1.sol#36) lacks a zero-check on :
		- wETH = _wETH (ControllerV1.sol#45)
ControllerV1.initialize(IERC20,address,address,address,address,DexAggregatorInterface,bytes)._lpoolImplementation (ControllerV1.sol#37) lacks a zero-check on :
		- lpoolImplementation = _lpoolImplementation (ControllerV1.sol#46)
ControllerV1.initialize(IERC20,address,address,address,address,DexAggregatorInterface,bytes)._openlev (ControllerV1.sol#38) lacks a zero-check on :
		- openLev = _openlev (ControllerV1.sol#47)
XOLE.setDev(address).newDev (XOLE.sol#172) lacks a zero-check on :
		- dev = newDev (XOLE.sol#173)
XOLE.delegateBySigs(address,uint256[],uint256[],uint8[],bytes32[],bytes32[]).delegatee (XOLE.sol#360) lacks a zero-check on :
		- (success) = address(this).call(abi.encodeWithSelector(XOLE(address(this)).delegateBySig.selector,delegatee,nonce[i],expiry[i],v[i],r[i],s[i])) (XOLE.sol#363-365)
XOLEDelegator.constructor(address,DexAggregatorInterface,uint256,address,address,address).implementation_ (XOLEDelegator.sol#23) lacks a zero-check on :
		- implementation = implementation_ (XOLEDelegator.sol#33)
XOLEDelegator.constructor(address,DexAggregatorInterface,uint256,address,address,address)._admin (XOLEDelegator.sol#22) lacks a zero-check on :
		- admin = _admin (XOLEDelegator.sol#36)
XOLEDelegator.setImplementation(address).implementation_ (XOLEDelegator.sol#43) lacks a zero-check on :
		- implementation = implementation_ (XOLEDelegator.sol#45)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#missing-zero-address-validation

[ColaM12]

Duplicate to #57