Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #27

Open
code423n4 opened this issue Mar 11, 2022 · 0 comments
Open

Gas Optimizations #27

code423n4 opened this issue Mar 11, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Don't Initialize Variables with Default Value

Impact

Issue Information: G001 - variables with default value

Findings:

../code4rena/2022-03-biconomy/contracts/hyphen/ExecutorManager.sol::31 => for (uint256 i = 0; i < executorArray.length; ++i) {
../code4rena/2022-03-biconomy/contracts/hyphen/ExecutorManager.sol::47 => for (uint256 i = 0; i < executorArray.length; ++i) {
../code4rena/2022-03-biconomy/contracts/hyphen/LiquidityFarming.sol::266 => uint256 accumulator = 0;
../code4rena/2022-03-biconomy/contracts/hyphen/WhitelistPeriodManager.sol::180 => for (uint256 i = 0; i < _addresses.length; ++i) {
../code4rena/2022-03-biconomy/contracts/hyphen/WhitelistPeriodManager.sol::228 => for (uint256 i = 0; i < _tokens.length; ++i) {
../code4rena/2022-03-biconomy/contracts/hyphen/WhitelistPeriodManager.sol::247 => uint256 maxLp = 0;
../code4rena/2022-03-biconomy/contracts/hyphen/token/LPToken.sol::77 => for (uint256 i = 0; i < nftIds.length; ++i) {
../code4rena/2022-03-biconomy/contracts/hyphen/token/TokenManager.sol::78 => for (uint256 index = 0; index < tokenConfig.length; ++index) {
../code4rena/2022-03-biconomy/contracts/hyphen/token/svg-helpers/SvgHelperBase.sol::29 => uint256 count = 0;
../code4rena/2022-03-biconomy/contracts/hyphen/token/svg-helpers/SvgHelperBase.sol::45 => for (uint256 i = 0; i < _length; ++i) {
../code4rena/2022-03-biconomy/contracts/hyphen/token/svg-helpers/SvgHelperBase.sol::68 => uint256 leadingZeroesToAddBeforeDecimal = 0;

Tools used

c4udit

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Mar 11, 2022
code423n4 added a commit that referenced this issue Mar 11, 2022
This was referenced May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant