Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Optimizations #87

Open
code423n4 opened this issue Apr 1, 2022 · 0 comments
Open

Gas Optimizations #87

code423n4 opened this issue Apr 1, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

  • CoreCollection: onlyUnInitialized and tokenExists modifier are declared but never used.
  • CoreCollection: the internal function _baseURI is declared but never used.
  • CoreCollection.setStartingIndex() function can be priavte. (no need to be public)
  • ERC721Payable: onlyVaultInitialized modifier is declared but never used.
  • Splitter : attemptETHTransfer and amountFromPercent functions are declared but never used.
    • The unchecked block can be used for all the for loops. Consider adding an internal function _increment with an unchecked block and use it to increment the counter inside the for loop.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 1, 2022
code423n4 added a commit that referenced this issue Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

1 participant