Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #24

Open
code423n4 opened this issue Mar 18, 2022 · 1 comment
Open

QA Report #24

code423n4 opened this issue Mar 18, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

1. Variable _initialAmount in function hook is unused.

Impact

  • Function hook in DepositHook.sol had an input variable _initialAmount but didn’t use anywhere in the function. Same issue with _initialAmount in WithdrawHook.sol

Proof of concept

Recommended Mitigation Steps

  • Remove variable _initialAmount
@code423n4 code423n4 added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax bug Something isn't working labels Mar 18, 2022
code423n4 added a commit that referenced this issue Mar 18, 2022
@code423n4
minhquanym issue #24
0781be7
@ramenforbreakfast
Copy link
Collaborator

duplicate of #5

@ramenforbreakfast ramenforbreakfast added the duplicate This issue or pull request already exists label Mar 22, 2022
@gzeoneth gzeoneth removed the duplicate This issue or pull request already exists label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ramenforbreakfast @code423n4 @gzeoneth