Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #54

Open
code423n4 opened this issue Apr 26, 2022 · 0 comments
Open

QA Report #54

code423n4 opened this issue Apr 26, 2022 · 0 comments
Assignees
@chase-manning
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) reviewed Issues that Backd has reviewed (just for internal tracking, can ignore this)

Comments

@code423n4
Copy link
Contributor

Missing Zero Address Validation

Permalinks

  1. AddressProvider.addFeeHandler: https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/AddressProvider.sol#L63-L68
  2. AddressProvider.addAction https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/AddressProvider.sol#L79-85

Description

The address can be set to address zero (0x00...) which could result in unexpected behavior.

Mitigation

Setters of address type parameters should include a zero-address validation.

Missing Event on Important/State Changes Function

Permalinks

  1. AddressProvider.addFeeHandler: https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/AddressProvider.sol#L63-L68
  2. AddressProvider.removeFeeHandler: https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/AddressProvider.sol#L69-L73
  3. AddressProvider.freezeAddress: https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/AddressProvider.sol#L228-L233
  4. AddressProvider.executeAddress: https://github.com/code-423n4/2022-04-backd/blob/c856714a50437cb33240a5964b63687c9876275b/backd/contracts/AddressProvider.sol#L257-L267 partially emit event log only _setConfig, not _executeDeadline

Description

Important or state changes function should emit events upon successful execution for off-chain tracking.

Mitigation

An event of calling critical functions should be generated for security and off-chain monitoring purposes.
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 26, 2022
code423n4 added a commit that referenced this issue Apr 26, 2022
@code423n4
Kenshin issue #54
ea9829d
@chase-manning chase-manning added the reviewed Issues that Backd has reviewed (just for internal tracking, can ignore this) label Apr 28, 2022
@chase-manning chase-manning self-assigned this May 2, 2022
@chase-manning chase-manning added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chase-manning chase-manning

Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) reviewed Issues that Backd has reviewed (just for internal tracking, can ignore this)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chase-manning @code423n4