QA Report #226
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
QA
I. Variables are already their defaults.
TransmuterV2.sol
setPause() already exists to alter the flag. Therefore, there's no need to set isPaused=false in initialize() since that's the default before alteration.
StakingPools.sol
[https://github.com/code-423n4/2022-05-alchemix/blob/de65c34c7b6e4e94662bf508e214dcbf327984f4/contracts-full/StakingPools.sol#L188
[https://github.com/code-423n4/2022-05-alchemix/blob/de65c34c7b6e4e94662bf508e214dcbf327984f4/contracts-full/StakingPools.sol#L363
ThreePoolAssetManager.sol
[https://github.com/code-423n4/2022-05-alchemix/blob/de65c34c7b6e4e94662bf508e214dcbf327984f4/contracts-full/ThreePoolAssetManager.sol#L250
https://github.com/code-423n4/2022-05-alchemix/blob/de65c34c7b6e4e94662bf508e214dcbf327984f4/contracts-full/ThreePoolAssetManager.sol#L254
[https://github.com/code-423n4/2022-05-alchemix/blob/de65c34c7b6e4e94662bf508e214dcbf327984f4/contracts-full/ThreePoolAssetManager.sol#L353
https://github.com/code-423n4/2022-05-alchemix/blob/main/contracts-full/ThreePoolAssetManager.sol#L771-L773
https://github.com/code-423n4/2022-05-alchemix/blob/main/contracts-full/ThreePoolAssetManager.sol#L901-L902
II. Grammatical errors
Remove ‘is’ :
https://github.com/code-423n4/2022-05-alchemix/blob/de65c34c7b6e4e94662bf508e214dcbf327984f4/contracts-full/interfaces/alchemist/IAlchemistV2State.sol#L47
III. Use assignment operator( +=/-=) for better readability :
https://github.com/code-423n4/2022-05-alchemix/blob/main/contracts-full/StakingPools.sol#L379-L380
[https://github.com/code-423n4/2022-05-alchemix/blob/main/contracts-full/StakingPools.sol#L397-L398
The text was updated successfully, but these errors were encountered: