Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #20

Open
code423n4 opened this issue May 3, 2022 · 0 comments
Open

QA Report #20

code423n4 opened this issue May 3, 2022 · 0 comments
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

https://github.com/code-423n4/2022-05-runes/blob/main/contracts/ForgottenRunesWarriorsMinter.sol#L287
Below calculation can be done in sinle line. Variables elapsed and steps can be removed.

Replace
uint256 elapsed = block.timestamp - daStartTime;
uint256 steps = elapsed / daDropInterval;
uint256 stepDeduction = steps * dropPerStep;

With
uint stepDeduction = ((block.timestamp - daStartTime) / daDropInterval) * dropPerStep

https://github.com/code-423n4/2022-05-runes/blob/main/contracts/ForgottenRunesWarriorsGuild.sol#L99
Add a check if receipient is not same as msg.sender(). Although only owner can call this function, if attacker can get hold of contract, they can mint all token and trasnfer to seld.

https://github.com/code-423n4/2022-05-runes/blob/main/contracts/ForgottenRunesWarriorsGuild.sol#L140
Define a immutable constant MAX_WARRIORS = 20 and use it in below check. Also use revert() function instead of require to save gas fees.
require(
numWarriors > 0 && numWarriors <= 20,
'You can summon no more than 20 Warriors at a time'
);

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels May 3, 2022
code423n4 added a commit that referenced this issue May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Development

No branches or pull requests

1 participant