QA Report

[code423n4]

Vulnerability Report - Low and Non-Critical Risk Findings

Developer notes should be removed from production code

Comments in production code should not contain developer discussion or notes about known bugs or problems. These issues should be tracked elsewhere and resolved before being deployed.

Comments of this kind can also indicate potential avenues of attack for an adversary.

The following lines are affected:

2022-06-illuminate/lender/Cast.sol:9:        require(n <= type(uint128).max, ''); // TODO err msgs
2022-06-illuminate/lender/Element.sol:15:    // TODO audit structure / names / order-of-members etc...
2022-06-illuminate/lender/Element.sol:8:    // TODO are these established element names? kind? not type? etc...
2022-06-illuminate/lender/Element.sol:9:    // TODO In, Out vs GIVEN_IN, GIVEN_OUT. If those names are needed they should be GivenIn etc...
2022-06-illuminate/lender/Safe.sol:4:// TODO audit for which methods are needed
2022-06-illuminate/redeemer/Safe.sol:4:// TODO audit for which methods are needed