New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #299

Open

code423n4 opened this issue Jul 13, 2022 · 0 comments

Labels

bug G (Gas Optimization) old-submission-method sponsor disputed

Contributor

code423n4 commented Jul 13, 2022

https://github.com/code-423n4/2022-07-fractional/blob/e2c5a962a94106f9495eb96769d7f60f7d5b14c9/src/Vault.sol#L64:
the revert should be at start to avoid unnecessary wastage of gas

In https://github.com/code-423n4/2022-07-fractional/blob/e2c5a962a94106f9495eb96769d7f60f7d5b14c9/src/Vault.sol#L78 and https://github.com/code-423n4/2022-07-fractional/blob/e2c5a962a94106f9495eb96769d7f60f7d5b14c9/src/Vault.sol#L104 , the for loop can be optimised
for (uint256 i; i<length) {
unchecked {
++i;
}
}

code423n4 added bug G (Gas Optimization) old-submission-method labels

code423n4 added a commit that referenced this issue


          djxploit issue #299

aee629b

mehtaculous added the sponsor disputed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment