QA Report #454
Labels
bug
Warden finding
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
sponsor acknowledged
Technically the issue is correct, but we're not going to resolve it for XYZ reasons
1) Use modifier for frequently used access restrictions.
if (owner != msg.sender) revert NotOwner(owner, msg.sender);
is used multiple times in Vault.sol. Create a modifier for it to avoid redundancy.Functions where its used are:
2) When Changing owners the new owner should be zero-checked to avoid accidental loss or ownership.
Instance in
Vault.sol
:transferOwnership
function3) Missing emit statement in several functions in
Migration.sol
.Functions where an emit statement is missing are:
The text was updated successfully, but these errors were encountered: