Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #454

Open
code423n4 opened this issue Jul 14, 2022 · 0 comments
Open

QA Report #454

code423n4 opened this issue Jul 14, 2022 · 0 comments
Labels
bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

1) Use modifier for frequently used access restrictions.

if (owner != msg.sender) revert NotOwner(owner, msg.sender); is used multiple times in Vault.sol. Create a modifier for it to avoid redundancy.
Functions where its used are:

  1. install
  2. setMerkleRoot
  3. transferOwnership
  4. uninstall

2) When Changing owners the new owner should be zero-checked to avoid accidental loss or ownership.

Instance in Vault.sol:

transferOwnership function

3) Missing emit statement in several functions in Migration.sol.

Functions where an emit statement is missing are:

  1. propose
  2. join
  3. leave
  4. commit
  5. withdrawContribution
  6. migrateFractions
@code423n4 code423n4 added bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jul 14, 2022
code423n4 added a commit that referenced this issue Jul 14, 2022
@stevennevins stevennevins added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Warden finding QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

2 participants