QA Report #61
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
1. use of floating pragma
Contracts should be deployed with the same compiler version and flags that they have been tested with thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using, for example, an outdated compiler version that might introduce bugs that affect the contract system negatively.
NFTCollectionFactory.sol
NFTDropCollection.sol
NFTCollection.sol
NFTDropMarket.sol
NFTDropMarketCore.sol
CollectionRoyalties.sol
NFTDropMarketFixedPriceSale.sol
AdminRole.sol
MinterRole.sol
SequentialMintCollection.sol
ContractFactory.sol
FETHNode.sol
ContractFactory.sol
FoundationTreasuryNode.sol
MarketFees.sol
MarketSharedCore.sol
2. _safemint() should be used rather than _mint() wherever possible
NFTCollection.sol#L130
NFTCollection.sol#L143
NFTCollection.sol#L159
NFTCollection.sol#L271
NFTDropCollection.sol#L182
3. event is missing indexed fields
Each event should use three indexed fields if there are three or more fields
NFTDropMarketFixedPriceSale.sol#L79
MarketFees.sol#L71
The text was updated successfully, but these errors were encountered: