QA Report

[code423n4]

1. typo in comments

struc --> struct

• MIMOLeverage.sol#L42

paking --> packing

• MIMOVaultActions.sol#L14

aggegator --> aggregator

• MIMOManagedRebalance.sol#L48

• MIMOAutoRebalance.sol#L52

allowedVaration --> allowedVariation

• MIMOManagedRebalance.sol#L170

• MIMOAutoRebalance.sol#L254

rebalnce --> rebalance

• MIMOAutoRebalance.sol#L157

2. constants should be defined rather than using magic numbers

Even assembly can benefit from using readable constants instead of hex/numeric literals

• MIMOSwap.sol#L59

• MIMOAutoRebalance.sol#L180

• MIMOProxy.sol#L95

• MIMOProxy.sol#L138

3. lines are too long

Usually lines in source code are limited to 80 characters. Today’s screens are much larger so it’s reasonable to stretch this in some cases. Since the files will most likely reside in GitHub, and GitHub starts using a scroll bar in all cases when the length is over 164 characters, the lines below should be split when they reach that length

• MIMOManagedRebalance.sol#L14

4. should fix the version

Contracts should be deployed with the same compiler version and flags that they have been tested with thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using, for example, an outdated compiler version that might introduce bugs that affect the contract system negatively.

• MIMOProxy.sol#L2
• MIMOProxyFactory.sol#L2
• MIMOProxyRegistry.sol#L2