QA Report #297
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
SUMMARY
[L-01] REPLACE INLINE ASSEMBLY WITH
ACCOUNT.CODE.LENGTH
<address>.code.length
can be used in Solidity >= 0.8.0 to access an account's code size and check if it is a contract without inline assembly.There is 1 instance of this issue:
KernalUtils.sol#ensureContract
[N-01] INCORRECT COMMENT
Returns a bool flag for whether the tokens have been claimed, not the amount of tokens reclaimed.
There is 1 instance of this issue:
Governance.sol
[N-02] SAFEAPPROVE() IS DEPRECATED
safeApprove()
is deprecated in favor ofsafeIncreaseAllowance()
andsafeDecreaseAllowance()
.There are 2 instance(s) of this issue:
Operator.sol#configureDependencies
BondCallback.sol#configureDependencies
[N-03] OPEN TODOS
Code architecture, incentives, and error handling/reporting questions/issues should be resolved before deployment
There are 3 instance(s) of this issue:
Operator.sol#_addObservation
TreasuryCustodian.sol
TreasuryCustodian.sol#revokePolicyApprovals
The text was updated successfully, but these errors were encountered: