Skip to content

Commit

Permalink
Report for issue #194 updated by chrisdior4
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Oct 24, 2022
1 parent b244908 commit 4bf411b
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions data/chrisdior4-Q.md
Expand Up @@ -45,12 +45,26 @@
1.bytes32 constant _factorySlot = 0xa49f20855ba576e09d13c8041c8039fa655356ea27f6c40f1ec46a4301cd5b23;
1.https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/contracts/HolographBridge.sol#L126

#### Consider changing the name to: FACTORY_SLOT
1.Consider changing the name to: FACTORY_SLOT



#### File: HolographTreasury.sol
2.bytes32 constant _holographSlot = 0xb4107f746e9496e8452accc7de63d1c5e14c19f510932daa04077cd49e8bd77a;
2.https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/contracts/HolographTreasury.sol#L133

#### Consider changing the name to: HOLOGRAPH_SLOT
2.Consider changing the name to: HOLOGRAPH_SLOT



# Conditions should be inclusive

### Conditions should be >= or <= instead of only < or >, otherwise, these functions will fail.

#### File: HolographBridge.sol

1.if (gasPrice < type(uint256).max && gasLimit < type(uint256).max) {
1.https://github.com/code-423n4/2022-10-holograph/blob/f8c2eae866280a1acfdc8a8352401ed031be1373/contracts/HolographBridge.sol#L381

#### Consider changing it to:
1.if (gasPrice <= type(uint256).max && gasLimit <= type(uint256).max) {

0 comments on commit 4bf411b

Please sign in to comment.