Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #85

Open
c4-bot-6 opened this issue Feb 4, 2024 · 7 comments
Open

QA Report #85

c4-bot-6 opened this issue Feb 4, 2024 · 7 comments
Labels
bug Something isn't working grade-a Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax selected for report This submission will be included/highlighted in the audit report sufficient quality report This report is of sufficient quality

Comments

@c4-bot-6
Copy link
Contributor

c4-bot-6 commented Feb 4, 2024

See the markdown file with the details of this report here.

@c4-bot-6 c4-bot-6 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Feb 4, 2024
c4-bot-7 added a commit that referenced this issue Feb 4, 2024
c4-bot-2 added a commit that referenced this issue Feb 4, 2024
@c4-pre-sort c4-pre-sort added the sufficient quality report This report is of sufficient quality label Feb 9, 2024
@c4-pre-sort
Copy link

bytes032 marked the issue as sufficient quality report

@tserg
Copy link

tserg commented Feb 21, 2024

Good quality report.

@c4-judge
Copy link

alex-ppg marked the issue as grade-a

@c4-judge
Copy link

alex-ppg marked the issue as selected for report

@c4-judge c4-judge added the selected for report This submission will be included/highlighted in the audit report label Feb 26, 2024
@alex-ppg
Copy link

This QA report was selected as the best given that it had almost zero false positives, is well-formatted, and details multiple things of interest to the Sponsor.

To note, the following findings are "OOS":

  • L-05: This is a TODO comment and thus a known issue (we cannot claim that the Sponsor is unaware of a TODO comment being present)
  • NC-02: This is a known issue as the README itself specifies that the compiler version the warning arises from should be utilized

@C4-Staff C4-Staff added the Q-04 label Mar 1, 2024
@alex-ppg
Copy link

alex-ppg commented Mar 1, 2024

As a follow-up to my previous comment, I will clarify that:

  • I would downgrade L-04 to a Non-Critical finding
  • I would consider NC-04 as borderline valid given that the collateral onboarding documentation of Opus specifies that the tokens should not revert on 0 value transfers

Apart from these, everything else aligns with how I would judge these issues.

@thebrittfactor
Copy link

Just a note that C4 is excluding the invalid/OOS entries from the official report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-a Q-04 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax selected for report This submission will be included/highlighted in the audit report sufficient quality report This report is of sufficient quality
Projects
None yet
Development

No branches or pull requests

7 participants