Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force volume or speed repeatedly in one video or playlist, but only once per tab/session? #899

Closed
chirag127 opened this issue May 23, 2021 · 11 comments
Labels
Bug Bug or required update after YouTube changes 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe)

Comments

@chirag127
Copy link

chirag127 commented May 23, 2021

PROBLEM: I'm always frustrated when Force speed setting also force speed on the playing video. Let us imagine that i have set the playback force speed at 2x and then I have decrease the speed on the playing video by using playback speed on the video using shortcut to 1x. Then I have observed the speed of video become 2x after a couple of minutes.

SOLUTION: A clear and concise description of what I want to happen is that Do not force speed on playing video.

@chirag127 chirag127 added the help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) label May 23, 2021
@ImprovedTube
Copy link
Member

ImprovedTube commented May 23, 2021

hi @chirag127 ohh yes!

BTW many people talk about this, but yet the usecase seems experimental to me.
personally i can imagine using it permanently after we also...:

@ImprovedTube ImprovedTube added the Bug Bug or required update after YouTube changes label May 23, 2021
@chirag127
Copy link
Author

#551 is a different issue altogether . My issue apply to each and every on the YouTube as I think that it does not make sense to re bring the default default speed on any video if I changed the speed ( either decreased or increased )on the videos using playback speed shortcut.

it permanently after we

I think that you misunderstood my issue.
I'm not talking about remembering the speed set on the video . It is just for the time I'm watching the video. Let's say the video is of 1 hr and I have a default speed set at 2x and then I changed the speed to 2.5x using the shortcut then I what want is that the speed should remain 2.5x for the remaining time untill I reload the tab or changes the video. Talking about what the speed depends on the is the quality of the sound of the video and I don't think that there way that improved tube can detect if the quality of the sound is good or bad and as music video used to have to have good quality audio I tend to play them on the default speed.

So, I don't think that you can not implement it before #551 .

@ImprovedTube
Copy link
Member

true. can surely be fixed soon, thats why this is labeled "bug" (not "feature request")

AND from our perspective the whole topic is one. i.e. The reason i cant imagine doing that is that i will lose the seconds that i save from having to reset the speed often. And it seems your usecase, when fixed, might still only have 5000 users or 1%,
while the perfect/automatic one would certainly be enough to be noticed by all of our users and more.
so that's what seems relevant to share with you everybody who might come here still before (AND after) we will close this bug

@chirag127
Copy link
Author

chirag127 commented May 23, 2021

might still only have 5000 users or 1%,

I think that bugs needs to be fixed even if a feature have less users .

And the previous comment is also edited so

Hmm... These feature requests Seems unrelated to this bug according to me .

I already use sponsorblock and I will love to see if it's can be implemented to this extension (but I don't know what the licence of sponsorblock say about it)as I will be able to ditch sponsorblock and block tube . I already do not use adguard ,video speed controller and magic action for you tube because of this extension. I will have 1 extension instead of 5 if the above feature requests are implemented in improved tube .

Thanks you for the extension.

@ImprovedTube
Copy link
Member

yes, bugs should be fixed.

just another fact, that I thought of labeling/sorting this feature somehow, indicating it is still less of a general purpose/more of experiment🧪
maybe😮 I should get a conditional 0.85x, when tab isnt active.

'editing comments'😍

@starobots
Copy link

As my experience, when the user replay the live stream video, the playing speed control feature will become invalid.
I tested the gameplay stream video and television broadcast live stream video.
This issue happened about 1 week ago until now.

@gzzz
Copy link

gzzz commented May 29, 2021

Periodical speed forcing is very annoying.
I watching the video and already chosen a comfortable speed (different from the default speed), but in some cases, seems like every N minutes, the speed is forced to default.

I thing the cause is ImprovedTube.playerPlaybackSpeed() inside of the ImprovedTube.timeupdate function — it running at every onplay player event.

I don't know why it work this way (listen for onplay event), but when ImprovedTube.playerPlaybackSpeed() in the ImprovedTube.timeupdate was commented out, the issue is gone: the speed is only forced on page load and does not change until the end.

@ImprovedTube ImprovedTube added the 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) label May 30, 2021
@ImprovedTube
Copy link
Member

ImprovedTube commented May 30, 2021

@starobots #889
@gzzz great! you can directly make a pull request with such
(and if you want it to be perfect add comment in code + issue number)

gzzz added a commit to gzzz/YouTube-Extension that referenced this issue May 30, 2021
@gzzz
Copy link

gzzz commented May 30, 2021

you can directly make a pull request with such

Done.

But I am still doesn't clear the mean of the condition:

(ImprovedTube.latestVideoDuration !== this.duration)

Looks like video duration can change during playback and script want to catch this change.

@starobots
Copy link

@starobots #889
@gzzz great! you can directly make a pull request with such
(and if you want it to be perfect add comment in code + issue number)

Hey, thanks for reply.

I mean the replay or rebroadcast of the live stream is still play on 1.0 x speed.

For example, this video is the 'youtube auto-recording' gameplay live stream, it can't play on higher than 2.0 x speed, or the play speed is controlled by the extension.
(this video is a MMO game live stream record)
www.youtube.com/watch?v=1ljmvn3vKy8

And for the 'normal' video, this video can not play on 3.0 x speed.
(this video is a guide of online game)
www.youtube.com/watch?v=17WVlVkKhDM

*I just find the video that can not play on higher speed, it doesn't mean I always play the video on 3.0 speed.
**And also I just post these 2 videos for issue example, I didn't try to promote or ads the game or the video channel.

I always watch the News broadcast at higher speed.

Thanks dear developer.

@ImprovedTube ImprovedTube changed the title Do not force speed on playing video. Do not force speed on playing video / only in new tabs Jun 2, 2021
@ImprovedTube
Copy link
Member

#909
@starobots then you are reporting a new bug. what browser? just tried speed 4x with both videos in version and it worked.
thanks @gzzz

@ImprovedTube ImprovedTube changed the title Do not force speed on playing video / only in new tabs Don't force speed on playing video / only once per new tab? Jun 3, 2021
@ImprovedTube ImprovedTube changed the title Don't force speed on playing video / only once per new tab? Don't force volume or speed repeatedly in one video or playlist, but only once per tab/session? Jun 3, 2021
@ghost ghost added the Confirmed by Victor label Jun 14, 2021
@ghost ghost removed Confirmed by Victor Bug Bug or required update after YouTube changes labels Jul 20, 2021
@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes and removed help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe)
Projects
None yet
Development

No branches or pull requests

4 participants