Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init.js removing only one instance playing kludge #2356

Merged
merged 10 commits into from
Jun 11, 2024

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Jun 10, 2024

fixing up after dc56797
also partially fixes #2284 message spam by only sending messages to connected tabs we have permissions for.
still need to get rid or at least fix the blur/focus

# TAB FOCUS/BLUR
spam mentioned in #2299 (comment)

@raszpl
Copy link
Contributor Author

raszpl commented Jun 11, 2024

link doesnt work so I dont know which ones., but as the commit messasge says remove dead code

@ImprovedTube
Copy link
Member

greetings @MohamedLebda

@ImprovedTube ImprovedTube merged commit 77cd69d into code-charity:master Jun 11, 2024
1 check passed
@ImprovedTube
Copy link
Member

case 'download'
and chrome.scripting.executeScript (or does chrome.tabs.executeScript still work with manifest 3?)
@raszpl

@raszpl raszpl deleted the patch-5 branch June 11, 2024 18:38
@raszpl
Copy link
Contributor Author

raszpl commented Jun 11, 2024

'download' is dead code, its not used anywhere https://github.com/search?q=repo%3Acode-charity%2Fyoutube%20download&type=code
executeScript my fault, I used older version (4.938) when making the patch and didnt notice it changed after switch to manifest3.

@raszpl
Copy link
Contributor Author

raszpl commented Jun 11, 2024

fix of your edit #2370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants