Remove JaResource/Canary from StripePlatformCardController #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landongrindheim
force-pushed
the
908-remove-ja-resource-from-stripe-platform-card-controller
branch
from
3241ced
to
6312729
Compare
…rm-card-controller
begedin
approved these changes
Oct 9, 2017
landongrindheim
deleted the
908-remove-ja-resource-from-stripe-platform-card-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reliance on JaResource/Canary within StripePlatformCardController
I also removed
Policy.StripePlatformCard.delete?/2and its dependent tests as it isn't being exercised.References
Closes #908
Progress on: #864