Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing indexes for github_id to GithubComment, GithubIssue, GithubRepo #1080

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Add missing indexes for github_id to GithubComment, GithubIssue, GithubRepo #1080

merged 1 commit into from
Oct 18, 2017

Conversation

joshsmith
Copy link
Contributor

@joshsmith joshsmith commented Oct 17, 2017 •
edited
Loading

What's in this PR?

This adds missing unique indexes for github_id to GithubComment, GithubIssue, and GithubRepo.

References

Fixes #1076

@joshsmith joshsmith mentioned this pull request Oct 18, 2017
Open
begedin
begedin requested changes Oct 18, 2017
View reviewed changes
Copy link
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gonna need unique constraints on respective changesets to. I'll add them.

@begedin begedin force-pushed the 1076-add-missing-github-id-indexes branch from 4c70b43 to 797f854 Compare October 18, 2017 07:16
begedin
begedin previously approved these changes Oct 18, 2017
View reviewed changes
@begedin begedin force-pushed the 1076-add-missing-github-id-indexes branch from 797f854 to cc21eee Compare October 18, 2017 07:16
@joshsmith
Copy link
Contributor Author

👍

@begedin begedin merged commit f9f151f into develop Oct 18, 2017
@begedin begedin deleted the 1076-add-missing-github-id-indexes branch October 18, 2017 07:24
@begedin begedin mentioned this pull request Oct 18, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begedin begedin begedin approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshsmith @begedin