Remove JaResource/Canary from RoleSkillController #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
previously approved these changes
Sep 27, 2017
landongrindheim
force-pushed
the
902-remove-ja-resources-from-role-skill-controller
branch
from
f696442
to
9a101bc
Compare
joshsmith
force-pushed
the
902-remove-ja-resources-from-role-skill-controller
branch
from
9a101bc
to
ad25293
Compare
joshsmith
approved these changes
Sep 27, 2017
|
@landongrindheim sorry, merging so much this morning that I threw you right back into the same boat. I went ahead and rebased myself and will merge since I'm about to push up another PR. |
|
Got it! 🙌 |
|
Thanks!! Went back and accepted the invite. Appreciate the review :) |
landongrindheim
deleted the
902-remove-ja-resources-from-role-skill-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove JaResource/Canary from RoleSkillController
RoleSkill.changeset/2was made private and is now called by a new functionRoleSkill.create_changeset/2. This semantic change was made after observing some dialog in #966References
Closes #902
Progress on: #864