Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adding skills page #7

Closed
joshsmith opened this issue Jul 14, 2015 · 5 comments
Closed

Implement adding skills page #7

joshsmith opened this issue Jul 14, 2015 · 5 comments
Assignees
Milestone

Comments

@joshsmith
Copy link
Contributor

We need to implement the design finished in #6.

@begedin
Copy link
Contributor

begedin commented Jan 18, 2016

@scarfdestroyer This is a prettyt self-contained task, so it would be a good one for you to work on in parallel with the stuff I'm working on.

The design itself isn't ready yet, but the way it would work should be clear enough.

  1. There is /skills route with a general list of skills the user can pick from. They work as toggle buttons.
  2. User can toggle those skills so they are either selected or not selected. Selecting a skill creates a UserSkill record, deselecting it destroys it.

Note that skills can be categorized, so they need to be listed in category groups.

As for the "show me the projects" button, I don't think we can do anything about that yet, since we don't have a project list page yet. There will be a task to handle that separately - #43

image

@begedin
Copy link
Contributor

begedin commented Jan 18, 2016

@joshsmith It's not completely clear if this works sort of like LinkedIn, where the user can also type in a skill and

  • If the skill already exists, a user skill is created
  • If the skill doesn't already exist, both a skill and a user skill are created

My guess for now is "no, we only have predefined skill records the user can pick from", but I wanted to make sure.

@scarfdestroyer Regardless of what Josh's answer is, proceed as if you only have a list of predefined skills and can't create new ones. If there will be actual skill creation, we can do that in a separate task.

@begedin
Copy link
Contributor

begedin commented May 9, 2016

@joshsmith I need your input here. I'm not blocked on starting work, but we need to figure out if it will be possible for the user to create new skills this way, or if it's just assigning predefined skills.

By this, I mean, a user want's to specify they're skilled with HTML, but there is no skill with that name in the database. Do we want to allow them to add it, which will create a Skill as well as a UserSkill record?

Based on the design, it's just a matter of picking skills out of the predefined list, but I'm not completely sure. What would the predefined list be in that case?

@joshsmith
Copy link
Contributor Author

I think for now just all predefined. We need to come up with a list of them. Maybe use stackshare or something as the basis for adding those initially?

Later we can consider having users add their own.

@joshsmith
Copy link
Contributor Author

Closed by #163.

joshsmith added a commit that referenced this issue Nov 9, 2017
# This is the 1st commit message:

Add admin UI for GitHub events

# This is the commit message #2:

Reorder UI, add navigation, add pagination

# This is the commit message #3:

Add admin navigation link

# This is the commit message #4:

Fix eslint

# This is the commit message #5:

Add beginning of tests

# This is the commit message #6:

Rename test and add currentRouteName assertion

# This is the commit message #7:

Add pagination helper function and get acceptance test passing

# This is the commit message #8:

Clean up paginate logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants