Make signup page responsive #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
reviewed
Feb 15, 2017
| @include shift(0); | ||
| @include span-columns(12); | ||
| padding: 0 8px; | ||
| } |
There was a problem hiding this comment.
Looks like there is some repetition on the sm-screen here.
Also, I see there being some padding on the last sm-screen. If we wrap the login in a .container, then it should be fine.
|
@joshsmith good catch. I removed the duplicate code and wrapped the form in a .container |
joshsmith
approved these changes
Feb 15, 2017
appleJax
force-pushed
the
responsive-signup-page
branch
from
2a13b88
to
05ba264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Makes signup page responsive.
Changes for smaller screens: