Add tests, switch tests to page objects #1 #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
changed the title
begedin
force-pushed
the
adding-tests-and-page-objects-1
branch
from
ef6ad96
to
b3de293
Compare
joshsmith
reviewed
Feb 20, 2017
| unit: true | ||
| } | ||
| ); | ||
|
|
There was a problem hiding this comment.
What is a unit component test vs an integration? Not sure I've seen this distinction.
There was a problem hiding this comment.
An integration test will partially boot the app (albeit not fully, like an acceptance test). It is also expected to render the component, which will have access to (and render) all subcomponents/services/etc.
The intention of an integration test it so check how the component is working with connected parts (while not fully starting the app) and how it interacts with the user/other layers.
The purpose of a component unit test would be to simply execute the component code to test, for example, some complex function within the component.
joshsmith
force-pushed
the
adding-tests-and-page-objects-1
branch
from
4e74671
to
f270c64
Compare
joshsmith
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Just a PR that adds some test coverage and moves a couple of existing test suites towards using page objects.
Changes
power-select/before-options. There is really no user interaction to be tested here, so a unit test is preferable.