Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic prismjs #1157

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add basic prismjs #1157

wants to merge 1 commit into from

Conversation

joshsmith
Copy link
Contributor

What's in this PR?

WIP. Adds syntax highlighting using Prism.js.

rileytaylor
rileytaylor approved these changes Mar 18, 2017
View reviewed changes
Copy link
Contributor

@rileytaylor rileytaylor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sidenote, can't seem to figure out how to undo approving a request)

Looks like just some ESlint errors, Prism needs to be defined. Otherwise, once that passes the rest of config looks good. Prism is great.

@joshsmith
Copy link
Contributor Author

I believe this still needs styling work done on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileytaylor rileytaylor rileytaylor approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshsmith @rileytaylor