Update ember-cli, babel and related dependencies. Fix issues. #1327
Conversation
| modulePrefix: 'code-corps-ember', | ||
| environment: environment, | ||
| environment, |
There was a problem hiding this comment.
This file was changed due to running ember init and manually merging. Makes it more eslint compliant.
ember-cli-build.js
Outdated
| 'ember-cli-babel': { | ||
| // async, await, etc. | ||
| includePolyfill: true | ||
| }, |
There was a problem hiding this comment.
Turns out we no longer need this. Probably due to ditching phantomjs. We used to need it to make use of async/await
package.json
Outdated
| "ember-cli-app-version": "^3.0.0", | ||
| "ember-cli-autoprefixer": "0.7.0", | ||
| "ember-cli-babel": "^5.2.4", | ||
| "ember-cli-babel": "^6.0.0", |
There was a problem hiding this comment.
6.0.0 is the one selected by ember-cli, but we should be safe to upgrade further.
begedin
force-pushed
the
update-ember-cli-and-babel
branch
from
aaeedeb
to
b278de1
Compare
| "ember-cli-app-version": "^3.0.0", | ||
| "ember-cli-autoprefixer": "0.7.0", | ||
| "ember-cli-babel": "^5.2.4", | ||
| "ember-cli-babel": "^6.4.1", |
There was a problem hiding this comment.
ember init sets the version to 6.0.0, but really, the problem was the transition from 5.x to 6.x, so no point not to upgrade further.
begedin
force-pushed
the
update-ember-cli-and-babel
branch
6 times, most recently
from
459348c
to
cf1598e
Compare
|
I was too quick to consider this done. There is an issue with There is also a resolved issue with |
| "ember-cli-bourbon": "2.0.0-beta.1", | ||
| "ember-cli-code-coverage": "0.3.12", | ||
| "ember-cli-code-coverage": "kategengler/ember-cli-code-coverage", |
There was a problem hiding this comment.
- 0.3.12 fails, related to babel
- The babel issue is fixed in master, but a new version has not been released yet.
package.json
Outdated
| @@ -75,15 +75,15 @@ | |||
| "ember-modal-dialog": "2.2.0", | |||
| "ember-moment": "7.3.1", | |||
| "ember-normalize": "1.0.0", | |||
| "ember-page-title": "^3.1.2", | |||
| "ember-page-title": "^3.2.0", | |||
There was a problem hiding this comment.
- 3.1.2 has an issue with ember-cli
- 3.2.0 fixes it, but there's a regression to an old issue we already have. I submitted a PR to fix it.
begedin
force-pushed
the
update-ember-cli-and-babel
branch
from
cf1598e
to
d6ad68a
Compare
|
@joshsmith We should consider merging this. The tests pass, but two addons which were causing trouble have to point at github master branches in order for the tests to pass, reason being, new versions have not been released yet. We cannot keep the old versions because they fail with new ember-cli. Greenkeeper will create PRs as those addons get updated anyway, and this finally takes us out of the woods with the recent ember-cli update issues. |
joshsmith
force-pushed
the
update-ember-cli-and-babel
branch
from
d749eb8
to
a2b5b37
Compare
joshsmith
force-pushed
the
update-ember-cli-and-babel
branch
from
53a54f1
to
2a74035
Compare
- Fixed test and runtime issues by getting rid of explicit use of Ember.Object as a file-declared constant - Unskip test - Remove reference to Phantom from USAGE.md - Improve team page
joshsmith
force-pushed
the
update-ember-cli-and-babel
branch
from
2a74035
to
622994c
Compare
This has been a long time coming and will close a couple of greenkeeper PRs as well as simplify our future upgrade processes.
My assumption was, the tests were failing once we update ember-cli (and with that, babel) due to a babel issue.
However, a bunch of babel issues were fixed and we still had this problem, so I did some debugging.
Turns out, our problem was doing this at a module level:
This code, when declared in a module root, would somehow mess with transpiling and overwrite
window.Object. At that point, a bunch of things would outright break.I resolved this issue by simply eliminating the need for even using
Object.createin those plases, by switching fromsomeObject.get/set('prop')toget/set(someObject, 'prop'). This is our conventional approach anyway, so any code that wasn't written this way was not convention compliant to begin with.