Fix bug in verification-document hbs that does not show if it's not errored #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires a test before merging. I haven't gotten to it yet. |
joshsmith
force-pushed
the
fix-bug-in-verification-document
branch
from
2467190
to
d46b10c
Compare
begedin
approved these changes
Oct 4, 2017
| </p> | ||
| {{#if (eq status 'errored')}} | ||
| <p class="error">Stripe was unable to verify your identity with the document you provided. Please try again.</p> | ||
| {{/if}} | ||
| {{#if error}} | ||
| <div class="error">{{error}}</div> |
There was a problem hiding this comment.
We got a div.error and a p.error here. Can they be shown at the same time and are we ok with how the margins are in that case?
joshsmith
force-pushed
the
fix-bug-in-verification-document
branch
from
d46b10c
to
e127750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This fixes a bug that displays an error (and the verification document itself) if the verification document process has errored somehow.