Write tests for services/project user #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
force-pushed
the
write-tests-for-services/project-user
branch
from
b57fecf
to
b17d7a9
Compare
joshsmith
previously requested changes
Nov 8, 2017
app/services/project-user.js
Outdated
| .save() | ||
| .then(() => this._flashSuccess('Your request has been sent.')) | ||
| .catch(() => this._flashError('Your request hasn not been sent.')); | ||
|
|
There was a problem hiding this comment.
Missing }, to close the function.
app/services/project-user.js
Outdated
|
|
||
| _flashError(message) { | ||
| let options = { fixed: true, sticky: false, timeout: 5000 }; | ||
| get(this, 'flashMessages').clearMessages().danger(message, options); | ||
| }); |
There was a problem hiding this comment.
Missing } to close the function.
| }); | ||
|
|
||
| test('it sends an error flash message if joinProject fails', function(assert) { | ||
| let service = this.subject(); |
There was a problem hiding this comment.
The test function on line 14 is not closed, and the test on line 54 is not indented correctly.
|
Your last commits are both named |
joshsmith
reviewed
Nov 8, 2017
| service.joinProject(project).then(() => { | ||
| done(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
This test function is still not closed by a }); which means you're running right into the next test inside this test (which itself is not left indented correctly).
daveconnis
force-pushed
the
write-tests-for-services/project-user
branch
from
7b7ac7c
to
6116285
Compare
daveconnis
force-pushed
the
write-tests-for-services/project-user
branch
from
2179d5b
to
da188ff
Compare
… to include error message when projectJoin fails added flashOptions object to clear up code
joshsmith
force-pushed
the
write-tests-for-services/project-user
branch
from
da188ff
to
3244660
Compare
joshsmith
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Two tests for project-user component.
joinProject creates a new projectUser with properties {project, currentUser, role: 'pending'}
joinProject creates a flash notification on success
Fixes #1182