Add status filtering to GitHub events #1669
Conversation
|
I would really rather not add a ton of acceptance tests here. The downside of the added test run time is not really worth any guarantees seen by very few users. |
There was a problem hiding this comment.
Looks good. I generally agree with keeping acceptance tests to a minimum.
However, I also strongly believe we should test all features of the app with an acceptance test.
It may seem the two are at odds, but really, for me, that means we write big tests. If a single test can cover the whole feature sufficiently, such as the case of this PR, that's perfect.
The bulk of the slowness of an acceptance test is the app startup anyway, as far as I Know.
Generally, integration and unit tests should be small, but acceptance tests make sense to be big.
|
Added the missing assertions for the clear button |
|
I don’t think we’re terribly disagreed on acceptance tests, so curious what you think of this post: https://dockyard.com/blog/2016/03/28/prefer-integration-tests |
Add status filtering to GitHub events (#1669)
WIP.