Add refresh token endpoint #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
force-pushed
the
510-refresh-token
branch
from
2547313
to
fa9d5c6
Compare
barruumrex
approved these changes
Oct 2, 2016
| @@ -84,7 +84,8 @@ module.exports = function(environment) { | |||
| // ENV.APP.LOG_VIEW_LOOKUPS = true; | |||
|
|
|||
| ENV.API_BASE_URL = 'http://api.lvh.me:49235'; | |||
| ENV.SERVER_TOKEN_ENDPOINT = 'http://api.lvh.me:49235/login'; | |||
| ENV.SERVER_TOKEN_ENDPOINT = 'http://api.lvh.me:49235/token'; | |||
There was a problem hiding this comment.
You could make your life slightly easier by storing the sub-uri's in a constant and appending that to these env vars. That way when you need to change a route, you don't have to search for every instance of "login" or such.
There was a problem hiding this comment.
Thanks, will implement.
barruumrex
approved these changes
Oct 2, 2016
joshsmith
force-pushed
the
510-refresh-token
branch
from
2001d1e
to
3e94a7f
Compare
|
Thanks for code review @barruumrex 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Closes #510 by adding refresh token endpoint in conjunction with code-corps/code-corps-api#306
ember-simple-auth-tokenby settingtimeFactor(works now!)References
Fixes #510