Suggest default in switch statement

[cezarant]

Fixes #780
CC0120: Suggest default for switch statements (C#)

This is my first pull request, if there is a problem , like a feedback.
Thank you!

[coveralls]

Coverage decreased (-0.01%) to 91.584% when pulling 9a1d9c1 on cezarant:suggestDefault into a657cab on code-cracker:master.

[thorgeirk11]

Would simplify this down to:

if (!diagnostics.Any())

[cezarant]

Thanks for the feedback @thorgeirk11 !
I will make the changes indicated :)

[carloscds]

Hi @cezarant, this code not raise analyzer:

var s = false;
            switch (s)
            {
                case false:
                    {
                        break;
                    }
            }

[giggio]

There are several small problems, @cezarant, are you going to move forward with this PR?

[giggio]

@carloscds

Actually, this code:

var s = false;
            switch (s)
            {
                case false:
                    {
                        break;
                    }
            }

Should raise a diagnostic, as it does not have a case true. We can't go on trying to verify if s had an assignment, this would make this analyzer impossible to finish. We should keep the analysis to the switch statement, IMO.

[cezarant]

@giggio I will study more about the Code Cracker. I did not think I'd find so many difficulties in carrying out this analyzer. Forgive me for doing pull Request with a low coverage tests. I will be more cautious next time.

[carloscds]

@cezarant Thanks for your collaboration and go ahead!

[carloscds]

@cezarant Do you have some news about this ?

[cezarant]

Hi @carloscds I was waiting for feedback for Fix #808, but I can work here. Following the above suggestions. I think I have to make a rebasing of the code that was loaded. Right?

[carloscds]

@cezarant We can process this PR separately.

[cezarant]

Hi devs! Anybody here have had problems to build the project, when change of machine?
I receive this error (VSSDK1031) when i build.
I am making several attempts to resolve the error, but if someone has been there and can help me, I would appreciate

[carloscds]

@cezarant Here project is compiling. Do you check for any extension installed on last days ?

[cezarant]

Hello @carloscds I did a format in my notebook, and re-install the Visual Studio. It is the only abnormal thing I did. Now, i unmarked options on the VSIX tab, and seems to have settled.

If no IDE error happen more, I will upload the changes soon.

[carloscds]

@cezarant CodeCracker users VSIX project.

[cezarant]

@carloscds I had two problems with the original branch that gave rise to this PR:

• The build generate the error VSSDK1031, and only works when the retreat option to "Create VSIX during the build"
• The rebase is taking too long to be done

So, I clone the actual version of the code cracker, created a new branch and put the changes.
The new branch is able to merge, I wonder if you see any problem if I generate another pull request for this issue.
I did not want to do that. But it is giving a lot of work to restore the old branch.

[carloscds]

@cezarant This branch has some conflicts, can you update it ?

[cezarant]

@carloscds Being my first analyzer, the original branch of this pull request has unnecessary modifications to files that were not part of the issue. I created a new pull request, starting from the beginning and already contemplating the suggestions mentioned above.

It is a bad idea?

[carloscds]

@cezarant Look:

[cezarant]

Hello @carloscds i resolved the conflicts in the the branch that I used to create this pull request.
However, as this branch is quite old (06 Jun) , the comparison with the current code generated 217 modified files. Even though I made the rebasing.

I feel unsafe to perform the pull request that branch. I can make a new rebasing,
to reduce the number of modified files, but I think it would be better to close this pull request, and to continue on the PR #851.
Because in addition to having had an increase in test coverage, PR #851 had a much smaller number of modified files: only six.

I'm sorry to have created another pull request, but could not find another way to check test coverage.

[carloscds]

@cezarant If you will create a new PR, please close this.