Merge pull request #13790 from code-dot-org/ui-502-retry

Add retry on UI-test page load errors
code-dot-org · Mar 14, 2017 · 01b6998 · 01b6998
2 parents eb5fce2 + 05aac93
commit 01b6998
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/dashboard/test/ui/step_definitions/steps.rb b/dashboard/test/ui/step_definitions/steps.rb
@@ -79,9 +79,11 @@ def individual_steps(steps)
 Given /^I am on "([^"]*)"$/ do |url|
   check_window_for_js_errors('before navigation')
   url = replace_hostname(url)
-  @browser.navigate.to url
-  refute_bad_gateway
-  refute_site_unreachable
+  Retryable.retryable(on: RSpec::Expectations::ExpectationNotMetError, sleep: 10, tries: 3) do
+    @browser.navigate.to url
+    refute_bad_gateway
+    refute_site_unreachable
+  end
   install_js_error_recorder
 end
 

diff --git a/dashboard/test/ui/support/connect.rb b/dashboard/test/ui/support/connect.rb
@@ -5,6 +5,7 @@
 require_relative '../../../../deployment'
 require 'active_support/core_ext/object/blank'
 require_relative '../utils/selenium_browser'
+require 'retryable'
 
 $browser_configs = JSON.load(open("browsers.json"))