Update a couple event funcs to handle dynamic params

code-dot-org · Jun 5, 2018 · 610d227 · 610d227
1 parent 3dac1a3
commit 610d227
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/apps/src/gamelab/GameLabJr.interpreted.js b/apps/src/gamelab/GameLabJr.interpreted.js
@@ -176,12 +176,12 @@ function whenMouseClicked(event) {
 }
 
 function whenPressedAndReleased(direction, pressedHandler, releasedHandler) {
-  touchEvents.push({type: keyWentDown, event: pressedHandler, param: direction});
-  touchEvents.push({type: keyWentUp, event: releasedHandler, param: direction});
+  inputEvents.push({type: keyWentDown, event: pressedHandler, param: direction()});
+  inputEvents.push({type: keyWentUp, event: releasedHandler, param: direction()});
 }
 
 function clickedOn(sprite, event) {
-  touchEvents.push({type: mousePressedOver, event: event, param: sprite});
+  touchEvents.push({type: mousePressedOver, event: event, sprite: sprite});
 }
 
 function spriteDestroyed(sprite, event) {
@@ -348,7 +348,9 @@ function draw() {
     for (let i = 0; i < touchEvents.length; i++) {
       const eventType = touchEvents[i].type;
       const event = touchEvents[i].event;
-      const param = touchEvents[i].param && touchEvents[i].param();
+      const param = touchEvents[i].sprite ?
+        touchEvents[i].sprite() :
+        touchEvents[i].param;
       if (param && eventType(param)) {
         event();
       }

diff --git a/apps/test/unit/gamelab/GameLabJrTest.js b/apps/test/unit/gamelab/GameLabJrTest.js
@@ -164,7 +164,7 @@ describe('Game Lab Jr Helper Library', () => {
     addBehavior(sprite, () => eventLog.push('behavior 2 ran'));
     whenUpArrow(() => eventLog.push('key event ran'));
     whenMouseClicked(() => eventLog.push('touch event ran'));
-    whenTouching(sprite, otherSprite, () => eventLog.push('collision event ran'));
+    whenTouching(() => sprite, () => otherSprite, () => eventLog.push('collision event ran'));
 
     draw();